Prevent Shard Manager from processing until persistence succeeds#166
Merged
ghostdogpr merged 1 commit intoseries/2.xfrom Sep 19, 2025
Merged
Prevent Shard Manager from processing until persistence succeeds#166ghostdogpr merged 1 commit intoseries/2.xfrom
ghostdogpr merged 1 commit intoseries/2.xfrom
Conversation
civilizeddev
approved these changes
Sep 18, 2025
nox213
approved these changes
Sep 18, 2025
juhokim-dev
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When persisting to Redis (or other storage) fails, the Shard Manager still accepts new pods and keeps rebalancing. The problem is that if we restart the Shard Manager at that point, it will read an old state from the database and consider old assignments as current, which might end up in the situation where an entity is alive in 2 different places.
This PR makes the persistence synchronous (removed
forkDaemon) so that register, rebalance and start operations will wait until persistence is over with retries and potentially die if we keep failing.